feat: add custom base URL support for VertexAI provider #7900
+194
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add vertexBaseUrl field to provider settings schema - Update VertexHandler to use custom base URL via GeminiHandler - Update AnthropicVertexHandler to use custom base URL - Add UI checkbox and input field for custom base URL in Vertex.tsx - Add comprehensive tests for the new functionality Fixes #7899
dosubot
bot
added
size:L
4 tasks
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
src/api/providers/gemini.ts
Outdated
|
|
||
| // Use vertexBaseUrl if this is a Vertex handler, otherwise use googleGeminiBaseUrl | ||
| const baseUrl = | ||
| this.constructor.name === "VertexHandler" ? this.options.vertexBaseUrl : this.options.googleGeminiBaseUrl |
Contributor
There was a problem hiding this comment.
Using this.constructor.name === "VertexHandler" to detect a Vertex handler is brittle (e.g. it may break under minification). Consider using the provided isVertex flag (or another dedicated property) to decide which base URL to use.
| tools.push({ googleSearch: {} }) | ||
| } | ||
|
|
||
| // Use vertexBaseUrl if this is a Vertex handler, otherwise use googleGeminiBaseUrl |
Contributor
There was a problem hiding this comment.
The same base URL selection logic is repeated in both createMessage and completePrompt. Consider refactoring this logic into a shared helper to reduce duplication.
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
- Replace 'any' type with proper VertexOptions type in anthropic-vertex.ts - Use isVertex property instead of fragile constructor.name comparison in gemini.ts - Improve test assertions clarity by checking undefined explicitly
Member
|
This doesn't seem to be working, I can't see the Custom URL field |
github-project-automation
bot
moved this from PR [Needs Prelim Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for custom base URLs in the VertexAI provider, enabling users to proxy LLM API calls through an API gateway for per-user virtual API keys and usage reporting.
Changes
vertexBaseUrlfield to provider settings schemaTesting
Screenshots
The UI now includes a checkbox to enable custom base URL with an input field (similar to OpenAI and other providers):
Fixes #7899
Important
Adds custom base URL support for VertexAI provider, updating schema, handlers, UI, and tests.
vertexBaseUrltovertexSchemainprovider-settings.tsfor custom base URL support.AnthropicVertexHandlerandGeminiHandlerto use custom base URL if provided.Vertex.tsxnow includes a checkbox and input for custom base URL.anthropic-vertex.spec.tsandvertex.spec.tsto verify custom base URL functionality.GeminiHandlerandAnthropicVertexHandlerconstructors to handlevertexBaseUrl.This description was created by
for 1698100. You can customize this summary. It will automatically update as commits are pushed.